Repository navigation
[js-api] Fix AddressValueToU64's type errors - #2275
Merged
rossberg merged 2 commits intoOct 13, 2026
Merged
Conversation
Ms2ger
reviewed
Oct 12, 2026
Rename V to jsValue, add a note explaining the any-to-JS-value conversion, and bind ℝ(n) once instead of three times.
Collaborator
Author
|
All done, this reads better now. Thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two type-related errors in the
AddressValueToU64algorithm.1. JavaScript value vs IDL value
vhere isn't a JavaScript value, but an IDL value.It's whatever the caller's own IDL-declared
AddressValueargument resolved to after WebIDL's own argument-conversion step already ran.Both
ConvertToIntandToBigIntare defined over genuine JavaScript values, sovneeds converting back before either branch uses it:Both branches then read
Vinstead ofv.2. BigInt vs Mathematical value
The i64 branch's range check compares
n(a BigInt bound the line above via?ToBigInt) directly against the mathematical-value literals0/2^64 − 1, with no conversion.According to the ECMA-262 standard:
so the range check should be: