Repository navigation
[ConstraintAnalysis] Fix asymmetry in provesPair overlap check - #9258
Merged
Merged
Conversation
Fixes `provesPair` to symmetrically check disjointness using proven spans rather than exact spans, since a disjoint superset implies disjoint subsets. This addresses an assertion failure in `approximateOr` where asymmetric comparison of constraints incorrectly produced an OR-induced contradiction. Removes unreachable `empty()` span checks in `provesPair` since empty spans are only produced by immediate contradictions, which are evaluated to contradictions prior to reaching `provesPair`.
kripken
reviewed
Oct 13, 2026
| return False; | ||
| } | ||
| auto bSpans = b.getSpans(type); | ||
| auto bProvenSpans = b.getProvenSpans(type); |
Member
There was a problem hiding this comment.
Seems confusing to now have aSpans meaning "a's proven spans" while bSpans means "b's exact spans". Perhaps rename one?
Member
Author
There was a problem hiding this comment.
Done, renamed aSpans to aProvenSpans.
kripken
reviewed
Oct 13, 2026
kripken
left a comment
kripken
left a comment
Member
There was a problem hiding this comment.
Another option might be to change how we assert on when a contradiction arrives, but making it symmetrical seems nicer actually. lgtm % comment on variable names.
tlively
enabled auto-merge (squash)
October 13, 2026 23:17
kripken
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
provesPairto symmetrically check disjointness using proven spans rather than exact spans, since a disjoint superset implies disjoint subsets. This addresses an assertion failure inapproximateOrwhere asymmetric comparison of constraints incorrectly produced an OR-induced contradiction.Removes unreachable
empty()span checks inprovesPairsince empty spans are only produced by immediate contradictions, which are evaluated to contradictions prior to reachingprovesPair.