Skip to content

Add async support to run_query and implement polling for results - #10

Merged
semantiDan merged 5 commits into
mainfrom
feature/add-async-support-using-timbr-x-async-header
Jul 15, 2026
Merged

semantiDan merged 5 commits into
mainfrom
feature/add-async-support-using-timbr-x-async-header

Conversation

@wpbarco

@wpbarco wpbarco commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator
  • Introduced _build_headers function to manage request headers.
  • Added async_mode parameter to run_query for asynchronous query execution.
  • Implemented _poll_async_result function to handle polling for async results.
  • Created tests for async mode in test_async_query_stubbed.py.
  • Refactored user creation logic in test_user_impersonation.py for clarity.

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Task

Description

TESTS

Number of tests added/changed: 1 test suit was added

ADDITIONAL INFORMATION

  • Removes existing feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

wpbarco added 2 commits July 15, 2026 13:13
- Introduced _build_headers function to manage request headers.
- Added async_mode parameter to run_query for asynchronous query execution.
- Implemented _poll_async_result function to handle polling for async results.
- Created tests for async mode in test_async_query_stubbed.py.
- Refactored user creation logic in test_user_impersonation.py for clarity.
@wpbarco wpbarco self-assigned this Jul 15, 2026
@wpbarco
wpbarco requested a review from semantiDan July 15, 2026 10:55

@semantiDan semantiDan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👀

Manually and automatically tested 👨 🤖

Shipping it! 🚢

@semantiDan
semantiDan merged commit 6a49162 into main Jul 15, 2026
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants