Repository navigation
Keep DCR OAuth requests within the client's registered scopes - #2402
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | daa3e1f | Oct 27 2026, 05:05 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | daa3e1f | Commit Preview URL Branch Preview URL |
Oct 27 2026, 05:02 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dynamically registered OAuth client can only be authorized for the scopes it registered for. When a server later advertises more scopes (Mercury did), reconnecting reused the old client because reuse ignored scopes.
oauth.startthen requested every discovered scope, and the server refused withinvalid_scope. Reconnecting could never recover.origin_requested_scopes: the scopes the registration asked for.origin_scopes: the scopes the server registered, read from the registration response (RFC 7591 §3.2.1 lets the server narrow them); null when the response omitsscope.oauth.startnarrows discovered scopes to the server-registered set, the same way scope-limited first-party apps already do. Declared scopes outside it fail with a clear error before the authorize redirect.This PR's own Test check fails because one existing test assumed rows without recorded scopes are reused; #2403 updates it. Tests are in #2403.