Repository navigation
0.7.0: skip and skip_reason on test assets and test cases - #44
Merged
Merged
Conversation
Some tests always fail for a known reason, and should be turned off until the issue behind them is fixed. skip (default false) and an optional skip_reason go on TestAsset, PathfinderTestAsset, TestCase and PathfinderTestCase, and so on every asset and test case class; skipping a test case skips all of its assets. The Test Harness reports skipped tests as skipped and can be told to run them anyway. Both fields are optional, so existing data stays valid. Version 0.7.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S2yuREtzxTuRqVGp8Q8a6d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests always fail for a known reason, and we want them off until the issue behind them is fixed. This adds:
skip: a boolean, defaultfalse.skip_reason: optional text, eg the issue the test waits on.Both go on
TestAsset,PathfinderTestAsset,TestCaseandPathfinderTestCase, so every asset and test case class gets them, includingAcceptanceTestAssetandPerformanceTestCase. Skipping a test case skips all of its assets.The Test Harness (TranslatorSRI/TestHarness, separate PR) doesn't run skipped tests, but reports them as
SKIPPEDwith the reason, and--include_skippedruns them anyway.Compatibility
Both fields are optional, so existing data stays valid. Data that uses them needs 0.7.0, because the model rejects fields it doesn't know. So suites in NCATSTranslator/Tests shouldn't set
skipuntil the deployed harness is on 0.7.0.Changes
project/artifacts, regenerated with linkml 1.7.8 as before.tests/test_skip.pycovers the defaults, a skip with a reason, and a subclass.Testing
CI's steps (
poetry install --no-root,poetry install,make test) run locally with the latest Poetry on Python 3.10, 3.11 and 3.12. All pass: 42 tests, 4 skipped as before.After merging
Create the
v0.7.0release so it publishes to PyPI. The harness PR pinstranslator-testing-model==0.7.0.Generated by Claude Code