Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The custom-element update behavior is covered through the actual Redact rendering path, with no remaining actionable merge risk identified. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (1 skipped: 1 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: assigning custom element props as properties.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (1 skipped: 1 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create PR with unit tests
-
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
React 19 assigns a prop on a dashed tag as a property whenever the element
declares one, and only writes an attribute otherwise. setProp had no such
branch: every prop outside the IDL allowlist became an attribute, so an
object value reached a web component as the string "[object Object]".
Components whose API is a property — `<number-flow-react data={...}>` — took
their value only from whatever the library assigned itself on mount and never
saw another update.
The other dashed names React excludes are SVG elements, already ruled out by
`isSvg`; `annotation-xml` is the one that reaches here through MathML.
The added bytes fit the existing size budgets after rebasing onto main.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jb4ndC7Q2e5LUYo4DdXpZ4
632f2ce to
817bc8a
Compare
🦋 Changeset detectedLatest commit: 817bc8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 participant
React 19 assigns a prop on a dashed tag as a property whenever the element declares one, and only writes an attribute otherwise. setProp had no such branch: every prop outside the IDL allowlist became an attribute, so an object value reached a web component as the string "[object Object]".
Components whose API is a property —
<number-flow-react data={...}>— took their value only from whatever the library assigned itself on mount and never saw another update.The other dashed names React excludes are SVG elements, already ruled out by
isSvg;annotation-xmlis the one that reaches here through MathML.The added bytes fit the existing size budgets on current main, so
scripts/size-check.mjsis unchanged.Summary by CodeRabbit
Bug Fixes
data-*, andaria-*values continue to use attributes, while SVG and MathML behavior remains unchanged.Documentation