Repository navigation
Fix web library import on net48: TLS 1.2 + working Refresh/cache TTL (#372, #374) - #373
Merged
Merged
Conversation
Since the .NET Framework 4.8 port, every HTTPS call from the add-in failed with "Could not create SSL/TLS secure channel". Excel is a native host and the add-in ships no .xll.config, so the AppDomain gets 4.0-era quirks and HttpClient offers TLS 1.0 only, which GitHub rejects. Web library import silently fell back to local sources and the update check always failed. Closes #372 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Refresh only dropped the in-memory provider; the rebuilt provider read the same disk cache back, so libraries cached months ago never updated. The CacheTtlMinutes setting was also never applied. - SourceCache takes an optional TTL and treats entries older than it as misses (null = no expiry, matching the 0 setting). - LibraryProvider.RefreshAsync(invalidateCache: true) wipes the repo's disk cache before re-fetching; the ribbon Refresh uses it. - Commands build the provider through one factory that passes the TTL. Closes #374 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
jimmytacks
changed the title
taglotacks
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #372
Closes #374
Problem
Since the net48 port (#199), every HTTPS call from the add-in failed with
Could not create SSL/TLS secure channel, so only local sources loaded. Once that was fixed, smoke-testing showed the remote repo loading 51 lambdas against 145 locally: four libraries came from a disk cache written in April, and the ribbon Refresh did not help.Causes
ServicePointManager.SecurityProtocol. Excel is a native host and the add-in ships no.xll.config, so the AppDomain gets 4.0-era quirks and offers TLS 1.0 only. GitHub requires TLS 1.2+.CacheTtlMinuteswas never applied, so cached libraries never expired.Fix
AddIn.AutoOpenenables TLS 1.2/1.3 before any HTTP call.SourceCachetakes an optional TTL and treats older entries as misses.LibraryProvider.RefreshAsync(invalidateCache: true)wipes the repo disk cache first; ribbon Refresh uses it.Testing
TagloGit/lambda-bossand the log lineGitHubSource: Fetched library 'array'(and the other three previously stale libraries).🤖 Generated with Claude Code