Repository navigation
refactor(ui): MVC split MainWindow and related classes - #1548
Merged
Merged
Conversation
CyanVoxel
added
Type: Refactor
github-project-automation
Bot
moved this from 🍃 Pending Merge
to ✅ Done
in TagStudio Development
2 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is targeting the
devbranch for release with Alpha v9.7.Summary
This PR splits the
MainWindowand related classes per the MVC guidelines. Related classes include theMenuBar,LandingPage, a newSearchBarclass, and a newBrowsingAreaclass. These split classes hold whichever widgets their responsible for and makes it easier to rearrange and change for upcoming UI updates.A lot of widget initialization and signal/callback connecting has also been moved out of the
QtDriverand into its respective classes, bringing the size of the driver down by about 360 lines. This is part of an ongoing effort to clean up and tame that thing.Progress on #1460.
Tasks Completed