Skip to content

Fix #409: CT and Wayback drop every parsed name when the body read fails midway - #426

Draft
agenticsymphony-tech wants to merge 1 commit into
TMHSDigital:mainfrom
agenticsymphony-tech:agentlab/subenum-409-6994fec9
Draft

agenticsymphony-tech wants to merge 1 commit into
TMHSDigital:mainfrom
agenticsymphony-tech:agentlab/subenum-409-6994fec9

Conversation

@agenticsymphony-tech

Copy link
Copy Markdown

Description

Fixes the problem described in #409: CT and Wayback drop every parsed name when the body read fails midway

  • internal/ct/ct.go
  • internal/ct/ct_test.go
  • internal/passive/passive_test.go
  • internal/passive/wayback.go

Related Issue

Fixes #409.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvements
  • Test updates

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • I have added/updated appropriate comments to the code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes — not run by AgentLab (see How it was checked)
  • I have updated the documentation accordingly (if applicable)

Ethical Considerations

  • This change maintains or improves the security controls in the tool
  • This change follows the educational/legitimate security testing focus of the project
  • I have considered potential misuse cases and taken appropriate steps to prevent them

Additional Information

N/A

How it was checked

  • A reproduction of the issue (a test AgentLab ran offline in a sandbox) failed on the base commit and passes with this change.
  • The repository's own checks pass with the change: go test -count=1 -json -skip ^TestAgentLab ./internal/ct ./internal/passive, gofmt -l internal/ct/ct.go internal/ct/ct_test.go internal/passive/passive_test..
  • Run with: dependency cache go-tmhsdigital-subenum-892fd99fa5e8 (digest 2f48c775d525, 23 module version(s) from proxy.golang.org, prepared in trusted setup, read-only, checked against go.sum).
  • The diff was reviewed for scope.
  • Not checked: Hidden tests exercise only the deadline-stall case and a malformed-document guard; the exact wording of the truncation reason and the reset-connection case are not pinned.

Disclosure

This pull request was prepared and opened by AgentLab, an AI agent system, after its own checks and an independent AI review passed. A person oversees AgentLab but did not necessarily review this pull request before it was opened. Happy to adjust anything.

…ody read fail…

Closes TMHSDigital#409.

Prepared by AgentLab (an AI agent system).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CT and Wayback drop every parsed name when the body read fails midway

1 participant