Repository navigation
fix(tui): confirm before overwriting saved results - #391
Merged
TMHSDigital merged 1 commit intoNov 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Saving from a finished TUI scan can export only the filtered or retained results. When the destination already exists, the first Enter now leaves it unchanged and displays an overwrite confirmation; a second Enter confirms the save. Editing the path, cancelling or reopening the prompt clears the confirmation. New files keep the existing one-Enter behavior.
The regression exercises both the scan's original output and a different existing file with a filtered result list. It checks that the first Enter, editing and cancellation preserve the original bytes, then verifies an explicit confirmation saves the filtered result. The overwrite action stays before the path in the hint so a long path cannot hide it.
Related Issue
Fixes #360.
Type of Change
Checklist
Ethical Considerations
Additional Information
Validated on macOS arm64 with Go 1.26.11 and golangci-lint 2.15.0:
go test -race -shuffle=on ./...passes all 21 packages with tests;make lintreports 0 issues;make build, gofmt andgit diff --checkpass.AI assistance: OpenAI Codex investigated and implemented the fix, ran the checks and drafted this PR. No separate human review is claimed.