Repository navigation
fix: defer permutations after a scan time-budget stop - #390
Merged
TMHSDigital merged 2 commits intoNov 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the main scan ends because its time budget is spent, stop without constructing or starting a permutation pass. The CLI now uses its existing unfinished-pass predicate; the TUI checks the expired flag before transitioning to permutation.
The CLI regression limits a single worker to 10 names/s with three names and a 1ms budget, adds an explicit seed, checks that no permutation announcement/report/state is produced, then resumes with an unlimited budget and rate and verifies that the deferred pass completes. The TUI regression sends an expired final event and verifies that the scan ends.
Related Issue
Fixes #373.
Type of Change
Checklist
Ethical Considerations
Additional Information
Validated on macOS arm64 with Go 1.26.11 and golangci-lint 2.15.0:
go test -race -shuffle=on ./...passes all 21 packages with tests;make lintreports 0 issues;make build, gofmt andgit diff --checkpass.AI assistance: OpenAI Codex investigated and implemented the fix, ran the checks and drafted this PR. No separate human review is claimed.