Repository navigation
test(cli): cover malformed diff baseline inputs - #388
Merged
TMHSDigital merged 1 commit intoNov 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add parser coverage for truncated JSON, unterminated CSV quoting, short CSV rows, and a bad middle JSONL line. The tests require a whole-file error with no partial result set. CLI tests try each malformed file as both operands of
subenum diff, requiring exit 1, no stdout and a diagnostic identifying the bad path.Also pin UTF-8 BOM handling and the existing text-diff behavior: all named lines, including
- old.example.com, enter the baseline's name set.One correction to the issue's suggested expectation: the current CSV reader enforces the header's field count, so a one-column row is rejected before the parser's short-row branch. This PR preserves that behavior rather than silently accepting a corrupt structured file. No production behavior changes.
Related Issue
Fixes #368.
Type of Change
Checklist
Ethical Considerations
Additional Information
Validated on macOS arm64 with Go 1.26.11 and golangci-lint 2.15.0:
go test -race -shuffle=on ./...passes all 21 packages with tests;make lintreports 0 issues; gofmt andgit diff --checkpass.AI assistance: OpenAI Codex investigated the issue, added the tests, ran the checks and drafted this PR. No separate human review is claimed.