Skip to content

ci: bound workflow jobs with explicit timeouts - #387

Merged
TMHSDigital merged 1 commit into
TMHSDigital:mainfrom
laozhej:codex/364-ci-timeouts
Nov 16, 2026
Merged

TMHSDigital merged 1 commit into
TMHSDigital:mainfrom
laozhej:codex/364-ci-timeouts

Conversation

@laozhej

@laozhej laozhej commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Description

Bound all 13 workflow jobs so a hung command cannot consume the default six hours. Build, OS tests, action tests and CodeQL have 20 minutes; release/image work has 30; the two devcontainer builds share 45; Pages, release installation and cleanup use smaller limits. The successful Go run 43879513905 took roughly 30 seconds to 3 minutes per active job, leaving substantial room for cold runners.

Related Issue

Fixes #364.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvements
  • Test updates

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • I have added/updated appropriate comments to the code
  • I have added tests that prove my fix is effective or that my feature works (configuration-only; checked every job and actionlint instead)
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly (if applicable)

Ethical Considerations

  • This change maintains or improves the security controls in the tool
  • This change follows the educational/legitimate security testing focus of the project
  • I have considered potential misuse cases and taken appropriate steps to prevent them

Additional Information

Validated on macOS arm64 with Go 1.26.11, golangci-lint 2.15.0 and actionlint 1.7.12:

  • Before the change, all 13 jobs lacked timeout bounds; afterward, every job has an explicit positive bound.
  • actionlint passes for all four workflows.
  • go test -race -shuffle=on ./... passes all 21 packages with tests; make lint reports 0 issues; git diff --check passes.
  • Tests used local DNS/HTTP fixtures and simulations. Hosted jobs were not deliberately hung to test cancellation.

AI assistance: OpenAI Codex inspected the issue and workflow timings, prepared the change, ran the checks and drafted this PR. No separate human review is claimed.

@TMHSDigital
TMHSDigital merged commit dd22631 into TMHSDigital:main Nov 16, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI jobs have no timeout-minutes, so a hung test holds a runner for six hours

2 participants