Repository navigation
fix(tui): use field defaults for blank numeric inputs - #383
Merged
TMHSDigital merged 1 commit intoNov 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clearing Concurrency, Timeout, Attempts, or Hit Rate now uses the field's built-in default instead of failing with “got 0.” Numeric parsing reads the defaults from
formFields, keeping the scan settings and saved form consistent. Explicit zero, negative, and non-numeric values still receive their existing validation errors where those values are invalid.The README documents blank-field behavior. Regression coverage compares empty and whitespace-only inputs with the default form across all eight integer fields and checks that invalid explicit values are still rejected.
Related Issue
Fixes #369.
Type of Change
Checklist
Ethical Considerations
Additional Information
Validated on macOS arm64 with Go 1.26.11 and golangci-lint 2.15.0:
go test -race -shuffle=on ./...passes the full suite (21 packages with tests).make lintreports 0 issues;make buildandgit diff --checkpass.The full suite used only local DNS/HTTP fixtures and simulations. An initial restricted run could not bind loopback sockets; the complete rerun with local socket access passed. Prepared with OpenAI Codex assistance.