Repository navigation
fix(cli): reject lab zones before starting the TUI - #382
Merged
TMHSDigital merged 1 commit intoNov 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
-tuiwith an active lab zone now exits with usage error 2 before opening the interface. Previously the TUI discarded-simulate-zone, leaving the form configured for a live scan. The diagnostic names whether the zone came from a flag,SUBENUM_SIMULATE_ZONE, or the config file and tells the user to run the lab without-tui.The README and lab guide describe the restriction. Six regression cases cover flags, interspersed arguments, no domain, environment/config defaults, and JSON diagnostics.
Related Issue
Fixes #356.
Type of Change
Checklist
Ethical Considerations
Additional Information
Validated on macOS arm64 with the pinned Go 1.26.11 toolchain and golangci-lint 2.15.0:
go test -race -shuffle=on ./...passes the full suite (21 packages with tests).make lintreports 0 issues;make buildandgit diff --checkpass.Tests use simulations and the repository's local DNS fixtures; no public resolver or live target was used. Prepared with OpenAI Codex assistance.