Repository navigation
Fix: Any resolver error text containing "refused" is counted as REFUSED (Resolves #377) - #380
Closed
luanpv2003 wants to merge 1 commit into
Closed
luanpv2003 wants to merge 1 commit into
luanpv2003 wants to merge 1 commit into
Conversation
…ng "refused" is counted as REFUSED
Owner
|
Thanks, but closing this one. Matching only the exact string "server refused the query (REFUSED)" breaks existing classification (TestClassify's "server refused" and "REFUSED" cases would fail), and the diff also removes the file's trailing newline. #377 stays open for a fix that tells RCODE REFUSED apart from socket errors without dropping those cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Resolves
Fixes #377
🛠 Summary of Changes
internal/dns/resolver.go🧪 Testing & Verification
Autonomously resolved & verified by NotchApp AI.
If this fix was helpful, tips are warmly welcome via Polar (Visa/Mastercard/Apple Pay).