Repository navigation
ci: test the Go minimum without racing the MCP source registry - #338
Merged
TMHSDigital merged 1 commit intoNov 15, 2026
Merged
TMHSDigital merged 1 commit into
TMHSDigital merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minimum CI leg now installs the version from the
godirective rather than the patchedtoolchaindirective. The Dependabot comment explains why Go 1.26.0 remains the supported floor.Running the suite with the actual Go 1.26.0 toolchain reproduced the existing race in the MCP source test: it replaced the process-wide registry while parallel sessions read it. Keep that single registry-mutating test serial, including cleanup, so the minimum-version check can pass reliably.
Fixes #323.
Fixes #302.
Validation on macOS arm64:
GOTOOLCHAIN=localused for all minimum-version tests.go test -race ./...passes on Go 1.26.0.go test -race -run TestE2EMCP -count=20 .passes on Go 1.26.0.make lintwith golangci-lint 2.15.0 reports 0 issues.version=1.26.0, despitetoolchain go1.26.11.git diff --checkpasses.AI assistance: OpenAI Codex investigated, implemented, reviewed and validated these changes. No independent human review is claimed.