Skip to content

ci: test the Go minimum without racing the MCP source registry - #338

Merged
TMHSDigital merged 1 commit into
TMHSDigital:mainfrom
laozhej:ci/test-go-minimum-without-registry-race
Nov 15, 2026
Merged

TMHSDigital merged 1 commit into
TMHSDigital:mainfrom
laozhej:ci/test-go-minimum-without-registry-race

Conversation

@laozhej

@laozhej laozhej commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

The minimum CI leg now installs the version from the go directive rather than the patched toolchain directive. The Dependabot comment explains why Go 1.26.0 remains the supported floor.

Running the suite with the actual Go 1.26.0 toolchain reproduced the existing race in the MCP source test: it replaced the process-wide registry while parallel sessions read it. Keep that single registry-mutating test serial, including cleanup, so the minimum-version check can pass reliably.

Fixes #323.
Fixes #302.

Validation on macOS arm64:

  • Official Go 1.26.0 archive checksum verified against go.dev release metadata; GOTOOLCHAIN=local used for all minimum-version tests.
  • go test -race ./... passes on Go 1.26.0.
  • go test -race -run TestE2EMCP -count=20 . passes on Go 1.26.0.
  • make lint with golangci-lint 2.15.0 reports 0 issues.
  • actionlint 1.7.12 validates the workflow (external shellcheck/pyflakes checks disabled).
  • Executed the workflow's extraction step against the current go.mod: version=1.26.0, despite toolchain go1.26.11.
  • git diff --check passes.

AI assistance: OpenAI Codex investigated, implemented, reviewed and validated these changes. No independent human review is claimed.

@TMHSDigital
TMHSDigital merged commit bed3367 into TMHSDigital:main Nov 15, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI "minimum" leg builds with go1.26.11, so the go 1.26.0 floor is untested Parallel test swaps package variable mcpSources while other tests read it

2 participants