Repository navigation
fix: keep verbose and TUI diagnostics accurate - #336
Merged
TMHSDigital merged 1 commit intoNov 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329.
Successful lookups without records now log
No recordswith the requested record types instead ofFailed to resolve ... Error: <nil>. TUI launch warnings go through the configured diagnostics writer, so-log-format jsonkeeps every warning a JSON object.The CLI retains its early argument check before input files are read and removes the duplicate call from
validateFlags, documenting its precondition. The three stale comments now describe streamed JSON elements and the array being closed byFinish.Regression coverage uses the in-process DNS server for NODATA, found records and real DNS errors, and checks both TUI warnings against the JSON diagnostic schema. Existing text-warning and argument-order tests are retained.
Validation on macOS arm64, Go 1.27.4:
d0c56f0with the reported nil-error and plain-text warning output.go test -race ./...passes across all packages (SUBENUM_NETWORK_TESTS=0; no live targets).make lintpasses with golangci-lint 2.15.0, reporting 0 issues.AI disclosure: OpenAI Codex prepared and tested this change.