Repository navigation
MCP explain_stats: stop offering -resume after a budget ran out - #335
Merged
TMHSDigital merged 1 commit intoNov 15, 2026
Merged
TMHSDigital merged 1 commit into
TMHSDigital merged 1 commit into
Conversation
…Digital#320) A run that ends on -max-queries or -max-duration writes no resume state (only an interrupted run saves one), so the advice now says to raise the budget and run the scan again. TestE2EMCPExplainStats asserts the text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The MCP
explain_statstool told the agent to "continue with -resume" when a target had candidates skipped by-max-queries/-max-duration. A budget-limited run exits normally and writes no resume state (only an interrupted run callssaveResumeState), so that next step fails. The sentence now names only the step that works: raise the budget and run the scan again.TestE2EMCPExplainStats(which already runs a simulated-max-queriesscan) now asserts the advice says "raise it and run the scan again" and does not mention-resume.Related Issue
Fixes #320
Type of Change
Checklist
rg "continue with -resume"finds nothing else)Ethical Considerations
Additional Information
Verified locally with Go 1.27.3:
go test -run TestE2EMCPExplainStats .fails on both calls ("...raise it, or continue with -resume.").go test -race -run TestE2EMCPExplainStats .passes,go vet .is clean, andgo test ./...passes. I did not runmake lint(golangci-lint is not installed here).If continuing a capped run is added later (the related enhancement), the sentence can mention
-resumeagain.