Skip to content

Dependency housekeeping: lipgloss ignore rule, stale doc SHAs, SPDX label #366

Closed

Description

@TMHSDigital

Summary

Three small dependency and packaging items.

1. Dependabot ignore rule now blocks lipgloss v2.1.1, which keeps go 1.26.0

  • Where: .github/dependabot.yml:15, .github/dependabot.yml:18, .github/dependabot.yml:19, .github/dependabot.yml:20, docs/DEVELOPER_GUIDE.md:325, docs/DEVELOPER_GUIDE.md:326, go.mod:10
  • What happens: dependabot.yml:15-20 ignores charm.land/lipgloss/v2 versions: [">= 2.1.0"] because "lipgloss v2.1.0 requires go 1.26.7"; DEVELOPER_GUIDE.md:325-326 repeats it ("lipgloss stays on v2.0.x for now"). go.mod:10 has charm.land/lipgloss/v2 v2.0.6. go list -m -u all reports charm.land/lipgloss/v2 v2.0.6 [v2.1.1]. The module files: v2.1.0's go.mod says go 1.26.7, v2.1.1's says go 1.26.0. The upstream v2.1.1 release (2026-11-15) notes: "This version just bumps down the minimum Go version to match our other libraries" (commit 036e4a4, "fix: bump down Go version (#783)"). In a scratch copy of go.mod/go.sum, go get charm.land/lipgloss/v2@v2.1.1 upgraded only lipgloss and left go 1.26.0, toolchain go1.26.11 and every other require unchanged. The ignore range is open-ended, so Dependabot will never offer v2.1.1 or any later v2.x release. (Dependabot's PR build(deps): bump charm.land/lipgloss/v2 from 2.0.6 to 2.1.0 in the go-modules group across 1 directory #284 proposed v2.1.0 the day before and was closed, correctly at the time.)
  • Impact: The direct TUI styling dependency stays on v2.0.6 indefinitely, with no automated signal when compatible fixes ship, although the reason for the hold (the go 1.26.7 floor) no longer applies to the current release. The docs state a constraint that is now stale.
  • To see it: In a scratch directory holding copies of go.mod and go.sum: go get charm.land/lipgloss/v2@v2.1.1, then read the go line (still go 1.26.0). go mod download -json charm.land/lipgloss/v2@v2.1.1 and read the GoMod file's go line.
  • Suggested fix: Narrow the ignore to the one bad release (versions: ["2.1.0"]) or drop it, upgrade to v2.1.1 (go get charm.land/lipgloss/v2@v2.1.1 && make tidy), and let the minimum CI leg (which now really runs go1.26.0) prove the floor. Update DEVELOPER_GUIDE.md:325-326 to state the rule without the v2.1.0 example, or note that v2.1.1 lowered it. Not verified here: that the repo builds and the TUI tests pass against v2.1.1 (an alternate-modfile build was refused by the sandbox); CI on the bump will show it.

2. Monitoring guide's example workflows pin stale action SHAs Dependabot never bumps

  • Where: docs/monitoring.md:107, docs/monitoring.md:243, docs/monitoring.md:272
  • What happens: docs/monitoring.md:107 and :272 use github/codeql-action/upload-sarif@2892aa5e19bbd11bc0cff5427e3b750a04d9e3c2 # v4; gh api repos/github/codeql-action/compare/2892aa5e...v4 reports the v4 tag 602 commits ahead (the pinned commit is dated 2026-09-24). The repo's own workflows pin codeql-action at 33d7b85d, which is the current v4 tag. docs/monitoring.md:243 uses actions/upload-artifact@043fb46d... # v7.0.1, while action.yml:246 and go.yml:105 pin cf430e03 (v7.0.2, the latest release). Dependabot's github-actions ecosystem (dependabot.yml:25-34) scans only workflow files and action.yml, not Markdown. Confirms lead from the previous audit (docs/monitoring.md:105, :220).
  • Impact: Users who copy the documented monitoring workflow (the guide's recommended setup) start on an old codeql-action and an older upload-artifact patch, and nothing in the repo warns when these pins age further.
  • To see it: gh api "repos/github/codeql-action/compare/2892aa5e19bbd11bc0cff5427e3b750a04d9e3c2...v4" --jq .ahead_by prints 602.
  • Suggested fix: Update the three pins to the SHAs the repo's own workflows use (codeql-action 33d7b85da1a04171e211befe2c739303b9a4c066 # v4, upload-artifact cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2), and add a check (a small CI step or a test, alongside the existing check-links.py) that every uses: owner/repo@sha in docs/*.md matches the SHA pinned for the same action in .github/workflows or action.yml.

3. Docker image licence label uses deprecated SPDX id GPL-3.0

  • Where: Dockerfile:59, CITATION.cff:18
  • What happens: Dockerfile:59 LABEL org.opencontainers.image.licenses="GPL-3.0". The OCI spec asks for an SPDX expression; GPL-3.0 is a deprecated SPDX identifier (replaced by GPL-3.0-only / GPL-3.0-or-later). CITATION.cff:18 already declares license: GPL-3.0-only, so the two metadata files disagree. Confirms lead from the previous audit (then Dockerfile:53).
  • Impact: Licence scanners and SBOM tools reading the GHCR image's labels report a deprecated or ambiguous licence, inconsistent with the citation metadata. Cosmetic; no legal effect on the LICENSE text itself.
  • To see it: docker inspect any published image and read the org.opencontainers.image.licenses label.
  • Suggested fix: Change the label to GPL-3.0-only to match CITATION.cff.

Acceptance criteria

  • Dependabot ignore rule now blocks lipgloss v2.1.1, which keeps go 1.26.0
  • Monitoring guide's example workflows pin stale action SHAs Dependabot never bumps
  • Docker image licence label uses deprecated SPDX id GPL-3.0

Getting started

  • Relevant files: .github/dependabot.yml, docs/DEVELOPER_GUIDE.md, go.mod, docs/monitoring.md, Dockerfile, CITATION.cff
  • How to run tests: go test ./... (tests must stay hermetic: use -simulate, a lab zone or internal/dnstest, never a live domain)
  • Related docs: docs/DEVELOPER_GUIDE.md, docs/ARCHITECTURE.md

Filed by repo-audit/full-audit at 0f3b0b6. Severity: low. Effort: S. audit-key: dependencies|.github/dependabot.yml|housekeeping

Activity

  1. TMHSDigital commented on Nov 16, 2026

    @TMHSDigital
    OwnerAuthor

    Fixed in a84e195.

    1. lipgloss: upgraded charm.land/lipgloss/v2 v2.0.6 to v2.1.1 (go.mod keeps go 1.26.0 and toolchain go1.26.11; only lipgloss changed). The Dependabot ignore now covers only 2.1.0, and the DEVELOPER_GUIDE paragraph says to check a release's go line instead of holding lipgloss on v2.0.x.
    2. docs/monitoring.md: upload-sarif now pins 33d7b85d (v4) and upload-artifact pins cf430e03 (v7.0.2), matching the workflows. A new test, TestDocsActionPinsMatchWorkflows, checks that every SHA-pinned uses: in docs/*.md and README.md matches a SHA the workflows or action.yml pin for the same action.
    3. Dockerfile: the licence label is now GPL-3.0-only, matching CITATION.cff. TestDockerLicenseLabelMatchesCitation keeps them aligned.

    How I verified it: both new tests failed on the old docs and Dockerfile and pass now. govulncheck@v1.9.0 ./... reports no vulnerabilities. gofmt, go vet, golangci-lint v2.15.0 and go test ./... all pass locally. The go1.26.0 minimum leg in CI tests the floor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions