Repository navigation
Say that redirects are not followed and baseUrl must be the final URL - #26
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (CI:
Finding fixed during review: README.md:235. The new paragraph had a stray line break before Do-not-auto-merge check: the paths are This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpURLConnectioncannot re-send it, a redirect is logged atFINEand the report is dropped, andbaseUrlmust be the final URL (https://when the server redirectshttp://there).TraceClient.builder(...)Javadoc says the same, so the class docs and the README agree.307/308would changesend()and remains a maintainer decision. A new issue can be opened if that behaviour change is wanted.The documented behaviour is already pinned by
report_aRedirectIsNotFollowedAndIsLoggedFine(added in #24), which asserts that the redirect target is never requested and that a FINEcould not deliver ... HttpRetryExceptionline is logged. The README wording says "a redirect" rather than "any3xx" on purpose: codes thatHttpURLConnectiondoes not try to follow (e.g.304, or308on Java 8) come back as a status and are logged astrace server answered <code>. They are still dropped atFINE.Test plan
mvn -B verifyrun locally on Java 21: 81 tests, 0 failuresCloses #25
Deferred issues
enabled: "false") touches the opt-out contract and needs a maintainer decision.withVersionexceedingMAX_TAGS) changes what is sent on the wire and needs a maintainer decision.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson