Repository navigation
Say what the logger hears and that queue drops are silent, in the Javadoc - #21
Conversation
…adoc Builder.logger said "Where dropped reports are mentioned", but a report dropped by the full queue goes through DiscardPolicy and is never logged, as the README's "Bounded" row has said since #20. The logger also hears more than drops: build() logs a server-wide config or install ID file it could not read or write. The Javadoc now lists what is logged and what is not. The class Javadoc's "It is bounded" bullet now says the drop is silent, matching the same README row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Self-review rubric (head 6aaeff9):
Repo-specific:
Judgment note: Do-not-auto-merge path check: only This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
…ged (#22) (#23) The drops-are-silent assertion from #20 required zero log lines, so one loopback send failing on the Java 8 runner turned main red after #21. Now only "could not deliver" lines are allowed, and far fewer of them than there were drops. A client that logged each drop still fails it, and the failure message prints the lines instead of only their count. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Stage A documentation accuracy sweep. Javadoc-only; no code, wire format or opt-out contract is changed.
Summary
Builder.loggerJavadoc said "Where dropped reports are mentioned". A report dropped because the queue is full goes throughDiscardPolicyand is never logged, which the README "Bounded" row has stated since Say that queue drops are silent and how the tags block skips lines #20. The logger is also handed more than drops:build()logs a server-wide config or install ID file that could not be read or written. The Javadoc now lists what is logged ([trace]-prefixed, atFINE) and states that queue drops are not.FINE, matching the same README row.The rest of the sweep (README example, "What
reportpromises", "Opting out", "Getting it", "The wire format", "Building", the class and method Javadoc,pom.xml, thebuild.ymlcomment) was checked againstTraceClient.javaand no other drift was found. The four version strings still agree at 0.6.1.Test plan
mvn -B verifylocally on Java 21:Tests run: 78, Failures: 0, Errors: 0, Skipped: 0build (8),build (17),build (21)greenDeferred issues
withVersionandMAX_TAGS): changes what is sent on the wire, so it waits for a maintainer decision.enabled: "false"): touches the opt-out contract, so it waits for a maintainer decision.No tracking issue: the drift was found during triage.
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson