Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
…loser The glint was added in linear space, which left a faint pink tint, so enchanted armour now adds the game's squared layers to its gamma-encoded colour in one pass. Armour boxes take the skin's z-fighting scale, and parts under leggings get the flat outer layer so the leggings can keep the game's thickness.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: The skin renderer could only draw the bare skin, so there was no way to show what a player is wearing.
renderSkintakes an optional{ armor }with a material per slot, a dye color for leather, and an enchant glint. Nothing calls it yet, feat(api): take armour, a cape, yaw and pose on skin renders #1196 wires it into the API.Testing:
renderSkin(skin, false, false, { armor: { chestplate: { material: "diamond", enchanted: true } } })shows a glinting diamond chestplate, and renders without armour match main.First in the stack #1192 → #1193 → #1194 → #1196.