Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Nov 11, 2026
jacobk999
reviewed
Nov 11, 2026
jacobk999
left a comment
jacobk999
left a comment
Member
There was a problem hiding this comment.
We should probably just use https://www.npmjs.com/package/nestjs-zod since it will also handle metadata for OpenAPI spec.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Jake wanted class-validator and class-transformer swapped for Zod, with Nest staying for now. Requests, defaults and coercion work the same, and the docs page only gains a number type on
sizefor/skin/head.PATCH /userand a single string for fields on the rankings endpoints now get a 400, where they used to save junk or throw a 500.Testing: 171 requests (everything the bots and site send, plus edge cases) through the old and new pipes give the same results apart from the two above and junk like
page=1e21, andGET /playerreturns a 400 with "player: Invalid input: expected string, received undefined".Depends on #1189