Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Most of apps/scripts was plain JS that nothing typechecked, so a few scripts broke without anyone noticing. Behavior is the same as before.
!. config() isn't awaited in api-key, delete-sessions, timestamp and rank-emojis, rank-emojis throws in its color loop (missing entries()), and validate-commands throws on a command with no options.Testing:
pnpm --filter scripts typecheckpasses, and validate-commands prints the same output as before on a sample commands.json.Conflicts with #1048 in api-key.ts and limit-redis.ts: keep its
await config(...)lines and drop the @ts-expect-error above the one in api-key.ts. Whichever lands second also has to change the limiter's command incompose.prod.ymltonode src/limit-redis.ts, since git won't flag it.