Skip to content

Fix settings.integration_events() to request the events path - #131

Open
lelia wants to merge 1 commit into
mainfrom
lelia/fix-integration-events-path
Open

lelia wants to merge 1 commit into
mainfrom
lelia/fix-integration-events-path

Conversation

@lelia

@lelia lelia commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

settings.integration_events() always failed. It requested GET orgs/{org_slug}/settings/integrations/{integration_id}, and that path has no GET route: the API only defines PUT and DELETE there.

Root Cause

The method's path stops at the integration ID. The integration events listing is one segment deeper, at .../integrations/{integration_id}/events.

Fix

  • Request orgs/{org_slug}/settings/integrations/{integration_id}/events. The endpoint checks integration:list.
  • Add a unit test that asserts the method and path.
  • Bump to 3.6.3, with a CHANGELOG entry.

Unit tests pass: 194 passed, 1 skipped.

#130 adds a scope table to the README that currently lists this method as "not in the API reference". Whichever PR merges second should update that row.

Public Changelog

Fixed settings.integration_events(), which requested a path with no GET route and always failed.

Refs: CE-462

The method requested orgs/{org}/settings/integrations/{id}, which has no
GET route, so it always failed. The events listing lives under /events
and checks integration:list.
@lelia lelia changed the title Fix settings.integration_events() to request the events path Fix settings.integration_events() to request the events path Nov 14, 2026
@lelia
lelia marked this pull request as ready for review November 14, 2026 02:45
@lelia
lelia requested a review from a team as a code owner November 14, 2026 02:45
@cursor

cursor Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Narrow bug fix to one settings client method path plus version and test; no auth or data-handling changes.

Overview
Fixes a broken SDK call by appending /events to the URL used by settings.integration_events(), so it hits the GET route that lists integration events instead of the integration resource path (which only supports PUT/DELETE).

Releases 3.6.3 with a CHANGELOG note and a unit test that checks the GET method and exact path.

Reviewed by Cursor Bugbot for commit 94df69d. Configure here.

@lelia

lelia commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 94df69d. Configure here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant