Skip to content

Keep namespaces in dependency source labels - #405

Open
John-David Dalton (jdalton) wants to merge 1 commit into
fix/python-package-namespacefrom
fix/python-ancestor-namespace
Open

John-David Dalton (jdalton) wants to merge 1 commit into
fix/python-package-namespacefrom
fix/python-ancestor-namespace

Conversation

@jdalton

@jdalton John-David Dalton (jdalton) commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Dependency-source labels now retain npm scopes and Maven groups, so distinct ancestor packages are not shown under the same name.

The namespace is included in package and alert provenance labels and in JSON introduced_by; manifest paths, ordering, and traversal behavior are unchanged.

Builds on #404. Validation: 30 focused tests plus scoped lint/format checks pass.

Preserve package scopes and groups in dependency source labels.

Identify scoped dependency ancestors correctly in package and alert
reports. Preserve manifest paths and existing traversal behavior.

Assisted-by: Codex:GPT-6
@lelia

lelia commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Heads up: #452 carries the same get_source_data change as this PR (keeping the namespace in ancestor labels), because it adds an "Introduced by" line to the default security comment and needed scoped npm and Maven ancestors to render correctly without waiting on the stack.

If #452 lands first, the socketsecurity/core/__init__.py hunk here becomes a no-op on rebase, and this PR could drop it and keep only the JSON/provenance tests. If this stack lands first, I'll resolve the conflict on #452. Either way works, no action needed unless you'd prefer to simplify here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants