Repository navigation
refactor(manifest): give a Maven sibling's jar and test-jar their own ids - #1716
Conversation
PR SummaryMedium Risk Overview Graph walking in Maven compat fixtures and tests are updated to pin per-artifact behavior (e.g. lib's jar prod via mid, test-jar direct in app, Reviewed by Cursor Bugbot for commit d55deef. Configure here. |
… ids The Maven facts extension wrote both a reactor sibling's jar and its test-jar under one bare groupId:artifactId:version id, so one record node mixed the two artifacts' scopes, directness and children, and the walk needed special cases for it. Each artifact now has its own coordinate and names the sibling module as its project; the assembler already merges a project's artifacts into its component, as it does for Gradle variants, so the facts are unchanged. Resolves REA-1165.
…es them Check that lib's jar is prod in app itself, not just in mid, and that mid's edge reaches it there; check liba's jar both names liba and has no file record. Read a coordinate's project without assuming a node row.
62a940a to
f6749d5
Compare
LLM Description written by Claude Code:claude-opus-5-5
The Maven facts extension wrote a reactor sibling's jar and its test-jar under one bare
groupId:artifactId:versionid. So one record node mixed the two artifacts' scopes, directness and children, and the walk needed special cases for it. Each artifact now has its own coordinate and names the sibling module as its project. The assembler already merges a project's artifacts into its component, as it does for Gradle variants, so the facts are unchanged. On the compat fixture,socket manifest mavenoutput is identical with the old and new extension.The fixture now pins the per-artifact records:
demo.ext:libdephangs under the test-jar, not the jar, since mid excludes it from lib.Maven compat matrix 3.2.5 to 4.0.0-rc-6 green. Suggested in the review of #1711.
Resolves REA-1165.
🤖 Generated with Claude Code