Repository navigation
Conversation
Member
|
I'll read in details later but I just have a quick comment so far. I don't think we should return an error when the rewrite is impossible. The idea is that rewrite will be identity when nothing can be improved, so that users (or even us) can call rewrite without a priori knowledge of the rewritability of the tensor, and let cten check that for them. |
Collaborator
Author
|
Cool, I checked what Rust allows:
Should I proceed as a whole or just do 1? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rewrite(tensor), which turns a tensor into an equivalent one that is cheaper to evaluate, or gives it back unchanged asErrwhen no identity applies.f ∘ Σ ∘ Ū ∘ ψ = Σ ∘ (f ∘ U)‾ ∘ ψ, so a zero-preserving function like square or relu is only applied to the stored values. It checks that f(0) = 0 and that the tensor is sparse.Sparsitytrait so that index functions (COO, Diagonal, EmptyMapping, InvProjection, InvAffine) can tell whether they send each index to at most one index.