Repository navigation
Support bibtexparser 2.x - #77
Conversation
Use parse_file and entry keys when the v2 API is available, while retaining the v1 loader path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the bibtexparser compatibility and Python 3.12 updates.
No open issues 🎉
What changed in this PR
Adds bibtexparser 2.x support to bibliography word loading while retaining compatibility with the v1 API. The PR also raises the minimum supported Python version to 3.12 and aligns CI and environment setup.
Changes:
- Uses
parse_fileand entry keys when available, falling back toloadandget_entry_dict. - Requires Python 3.12 and updates CI and publishing workflows accordingly.
- Replaces the pinned Conda environment with a minimal Python/pip specification and pip installation instructions.
| File | Description |
|---|---|
pyproject.toml |
Raises the Python minimum to 3.12 and adds its classifier. |
conda-env.txt |
Simplifies environment setup around Python 3.12. |
comment_spell_check/utils/bibtex_loader.py |
Supports both bibtexparser v1 and v2 APIs. |
.github/workflows/python-app.yml |
Updates both CI jobs to Python 3.12. |
.github/workflows/publish.yml |
Updates package publishing to Python 3.12. |
Review effort: Balanced
zivy
left a comment
There was a problem hiding this comment.
Why wasn't the code only modified to use bibtexparser 2.x and the requirements.txt changed to require 2.0 as a minimal version? Is there a need to support both bibtexparser 1.x and 2.x versions?
|
Yeah, I'll change it to v2 only |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| comment_parser | ||
| pyspellchecker | ||
| bibtexparser | ||
| bibtexparser>=2.0,<3 |
There was a problem hiding this comment.
This is a roundabout way to say bibtexparser~=2.0 which means any version from the 2.x family. Was there a reason for specifying it this way?
Summary
Validation