Repository navigation
Fix Function replay shutdown and process cancellation - #9057
Draft
isaacroldan wants to merge 1 commit into
Draft
isaacroldan wants to merge 1 commit into
isaacroldan wants to merge 1 commit into
Conversation
isaacroldan
force-pushed
the
codex/function-replay-shutdown
branch
5 times, most recently
from
November 3, 2026 13:06
f8ab107 to
dc6793d
Compare
isaacroldan
force-pushed
the
codex/function-replay-shutdown
branch
2 times, most recently
from
November 3, 2026 13:21
4cd3f94 to
6360547
Compare
isaacroldan
force-pushed
the
codex/function-replay-shutdown
branch
from
November 4, 2026 12:51
6360547 to
6c7547f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Ctrl-C should stop active Function execution and queued rebuilds before replay finishes. The first PR in this stack adds JSON output but leaves shared build and process shutdown behavior unchanged.
WHAT is this pull request doing?
Move the shutdown fixes from #9007 into this separate change. The original PR remains unchanged.
This PR is based on
codex/function-replay-json; its diff contains the shutdown fixes and their tests, not the JSON feature again. Runner cancellation and watcher cleanup apply to the shared replay loop used by both JSON output and the text UI.How to manually test your changes?
Use an app with a Function and a saved Function log.
pnpm shopify app function replay --path <function-directory> --log <log-id> --json --no-input.cancelled, and the command exits with code 130..build-lock. Cancel replay, then release the lock. Check that no new build starts.--jsonto check that text replay still works. Use--no-watch --jsonto check the single-result output.Validation
cancelledrecord and exit code 130.--version.Checklist