Repository navigation
Fix ship shortcut hints when dock indices have gaps - #341
Merged
Merged
Conversation
netniV
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dock F is locked but dock G is available, Show Hotkeys can label the sixth selectable ship as
7, although the mod selects it with6.Resolve each ship hint through
FleetBarContext.FleetData, matching the positional array used by mod ship selection. This preserves custom bindings and avoids advertising a shortcut when the fleet is unavailable or outside the eight supported positions.Validation: Windows releasedbg build and shortcut hint/binding tests passed, covering gapped and reordered indices, null entries, the eight-position limit, and a custom binding. No new detours or configuration changes. Runtime confirmation on the reporting account's layout and macOS build/runtime validation remain pending.