Skip to content

fix(guacamole): make the guacamole-server and guacamole-client git refs configurable - #43

Merged
solaechea merged 1 commit into
mainfrom
fix/guacamole-pin-ci-test-42
Nov 4, 2026
Merged

solaechea merged 1 commit into
mainfrom
fix/guacamole-pin-ci-test-42

Conversation

@solaechea

Copy link
Copy Markdown
Contributor

Written with Claude Opus 5.5

Description

Stopgap for #42. The guacamole role always built apache/guacamole-server and apache/guacamole-client from main. Since upstream commit 6f069e524e (2026-11-02), guacamole-server main no longer compiles on Debian 12, so Molecule (guacamole) fails on every PR and on main. Because the Release Please job needs every Molecule job to pass, no release can be cut either.

This PR:

  • adds guacamole_server_version and guacamole_client_version, the git refs the four ansible.builtin.git tasks check out, both defaulting to main, so existing runs build exactly what they built before;
  • documents both in meta/argument_specs.yml;
  • pins both to the 1.6.0 release in the Molecule scenario only.

Pinning the role's defaults to a release is left to #42, which stays open.

Refs #42

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New role or feature (non-breaking change which adds functionality)
  • Breaking change (variable renames, removed roles, changed behavior)
  • Documentation update
  • CI/workflow change

Role Convention Checklist

  • ansible-lint passes with zero failures and zero warnings (production profile, strict): not run locally, left to CI
  • Tasks use FQCN modules, gerund names, quoted modes, changed_when on commands
  • meta/argument_specs.yml and the role README updated for any variable or behavior change: argument_specs updated; the README has no variables section
  • No secrets in tracked files
  • Checked startcloud.startcloud_roles for overlap
  • Commit messages follow Conventional Commits

Testing performed

In a debian:12 container, with the role's build package list, autoreconf -fi && ./configure --with-systemd-dir=/etc/systemd/system, then make:

guacamole-server ref Result
1.6.0 (1f664e0) builds
main (bb1ba8e) fails: video.c:225:16: error: 'AVFrame' has no member named 'duration'

The guacamole-client 1.6.0 Maven build and the full scenario are covered by this PR's Molecule (guacamole) run.

Additional Context

The role finds the built WAR and the JDBC MySQL jar by glob (*.war, *.jar), so building client 1.6.0 while guacamole_version stays 1.5.0 (used only for paths and the installed jar name) doesn't change any lookups.

…fs configurable #42

The role always built both repositories from main, so any upstream commit
changed what it built. guacamole-server main no longer compiles on Debian 12
(AVFrame has no duration member in its FFmpeg).

guacamole_server_version and guacamole_client_version default to main, so
existing runs build the same refs as before. The Molecule scenario pins both
to the 1.6.0 release, which compiles on Debian 12.
@solaechea
solaechea merged commit 0b1650e into main Nov 4, 2026
33 checks passed
@solaechea
solaechea deleted the fix/guacamole-pin-ci-test-42 branch November 4, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant