Repository navigation
fix(guacamole): make the guacamole-server and guacamole-client git refs configurable - #43
Merged
Merged
Conversation
…fs configurable #42 The role always built both repositories from main, so any upstream commit changed what it built. guacamole-server main no longer compiles on Debian 12 (AVFrame has no duration member in its FFmpeg). guacamole_server_version and guacamole_client_version default to main, so existing runs build the same refs as before. The Molecule scenario pins both to the 1.6.0 release, which compiles on Debian 12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written with Claude Opus 5.5
Description
Stopgap for #42. The
guacamolerole always built apache/guacamole-server and apache/guacamole-client frommain. Since upstream commit6f069e524e(2026-11-02), guacamole-servermainno longer compiles on Debian 12, soMolecule (guacamole)fails on every PR and on main. Because the Release Please job needs every Molecule job to pass, no release can be cut either.This PR:
guacamole_server_versionandguacamole_client_version, the git refs the fouransible.builtin.gittasks check out, both defaulting tomain, so existing runs build exactly what they built before;meta/argument_specs.yml;1.6.0release in the Molecule scenario only.Pinning the role's defaults to a release is left to #42, which stays open.
Refs #42
Type of Change
Role Convention Checklist
ansible-lintpasses with zero failures and zero warnings (production profile, strict): not run locally, left to CIchanged_whenon commandsmeta/argument_specs.ymland the role README updated for any variable or behavior change: argument_specs updated; the README has no variables sectionstartcloud.startcloud_rolesfor overlapTesting performed
In a
debian:12container, with the role's build package list,autoreconf -fi && ./configure --with-systemd-dir=/etc/systemd/system, thenmake:1.6.0(1f664e0)main(bb1ba8e)video.c:225:16: error: 'AVFrame' has no member named 'duration'The guacamole-client
1.6.0Maven build and the full scenario are covered by this PR'sMolecule (guacamole)run.Additional Context
The role finds the built WAR and the JDBC MySQL jar by glob (
*.war,*.jar), so building client1.6.0whileguacamole_versionstays1.5.0(used only for paths and the installed jar name) doesn't change any lookups.