Repository navigation
Charts: season slider on the nurseries map (#172) - #177
Conversation
The map can step through the 13 seasons, or play them in turn, with circles on one catch-rate scale so frames are comparable. Nurseries not sampled with timed sets that season show as dashed rings. InteractiveMap now redraws its layers when they change, keeping the view and any layers the reader switched off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reviewed the three changed files and pushed a fix. [P2] Restore text-only map tooltips. The redraw loop in Fixed in 045cf04, with the browser test corrected in cfe1404: labels now use a DOM element populated with The season indexing, shared scale, redraw lifecycle and overlay retention otherwise look consistent. This branch passed lint, type checks, build, unit tests (118 passed; 2 real-data tests skipped), and the tooltip browser regression. The full combined stack additionally passed 41 browser tests. Fix propagated through #178, #179 and #184 without force-pushing. No spreadsheets changed. |
|
Re-reviewed current head cfe1404, including the earlier tooltip fix. No additional actionable findings. Checked season/row alignment, pooled versus per-season catch rates, shared size domain, missing-value rings, playback cleanup, CSV registration, and overlay redraw/visibility retention. Fresh validation on this branch: pnpm lint; pnpm check (0 errors/warnings); pnpm test (118 passed, 2 opt-in real-data tests skipped); pnpm build; pnpm test:e2e (39 passed, including the tooltip regression and light/dark axe checks). No further code changes needed. Review complete; proceeding to #178. |
Closes #172.
What
/nurseries. The last stop is "All seasons" (today's view); Play steps through seasons every 1.2 s and stops at 2025–26. Dragging the slider pauses playback.InteractiveMapnow redraws its layers when thelayersprop changes, keeping the view and any overlays the reader switched off. New optionalMapLayer.maxfixes the size scale.aria-valuetext; the SSR fallback is unchanged.Checks
pnpm lint,pnpm check,pnpm test,pnpm build,pnpm test:e2e(38 passed). Checked against the real data in the dev server: the slider, Play and the dashed rings work, and there is one layer control.#173 and #174 are stacked on this branch (they extend
InteractiveMaptoo), so merge this first.🤖 Generated with Claude Code