Repository navigation
MOD-18588 - change cbor recurse limit - #24
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 65aac9b. Configure here.
AvivDavid23
reviewed
Oct 6, 2026
| let recursion_limit = if limit_depth { | ||
| MAX_DEPTH as usize | ||
| } else { | ||
| usize::MAX |
There was a problem hiding this comment.
?
cant it be an option?
if from_reader_with_recursion_limit must recive usize call it only when you have limit_depth=true
Author
There was a problem hiding this comment.
no
when the flag is turn off we don't want to enforce the default 256 depth , but we want to have MAX_UNIT
AvivDavid23
requested changes
Oct 6, 2026
AvivDavid23
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes how deeply nested CBOR is accepted or rejected during decode, which can affect untrusted input handling and any code that relied on the old parser-only behavior.
Overview
CBOR decoding now applies a consistent depth cap at both the
ciboriumparse step and theIValueconversion step.decodestill enforces the existingMAX_DEPTH(128), but routes through a newdecode_with_depth_limitAPI that can turn that enforcement off.The parser switches from
from_readertofrom_reader_with_recursion_limit, usingMAX_DEPTHwhen limiting is on and mappingRecursionLimitExceededtoCborDecodeError::DepthLimitExceeded.cbor_to_ivalueonly rejects on depth whenlimit_depthis true, so callers can decode legitimately deep trees when they opt out.decode_with_depth_limitis re-exported from the crate root; a unit test covers nested arrays that fail under defaultdecodebut succeed with limits disabled.Reviewed by Cursor Bugbot for commit 678535e. Bugbot is set up for automated code reviews on this repo. Configure here.