Repository navigation
feat(mcp): run candle strategies, a data type on submit_backtest and submit_sweep - #14
Merged
Merged
Conversation
…submit_sweep The MCP could not request a kline run: sdk-java prepared every run as ticker data, so a strategy that reads candles over a klines dataset always ended FAILED at preparation. submit_backtest and submit_sweep take a type (ticker by default, or kline). get_job_status and get_equity_curve take it too for a job this session did not submit, because the platform addresses a result by exchange, type and job id, and a kline run is not found on the ticker route. A sweep remembers its type for its retained curves. Builds against sdk-java 0.35.0, which carries the type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The MCP server could not run a strategy that reads candles.
submit_backtesthad no data type, so a dataset run was always prepared as ticker data and a kline strategy over a klines dataset endedFAILED("This strategy reads kline data, but the run was submitted against ticker data").Change
submit_backtestandsubmit_sweeptaketype:ticker(the default) orkline. A kline run over adatasetIdneeds a ready dataset version oftype=klines; a ticker run accepts either. Any other value is refused before anything is submitted.get_job_statusandget_equity_curvetake the sametypefor a job this session did not submit, as they takeexchangeId: the platform addresses a result by exchange, type and job id, and a kline run is not found on the ticker route. A job this session submitted ignores it.sdk-java0.35.0 (published), which carries the type. Two commits: the change, andchore(release): 0.22.0(version and changelog).Tests
McpToolsTestcases: a request is a ticker run unless it asks for kline (name not case-sensitive); an unsupported type is refused and nothing is submitted;submit_sweeptakes the same type;get_job_statusandget_equity_curvepass the type to the service for a run from another session; and refuse one they cannot address.mvn verifypasses, including the native reflection-config guard.Not verified yet
The native image is built only on a tag, so the kline run over a dataset through the native binary is to be checked on that build. The same run through the SDK was checked against the live API when the SDK change was made.
After merging, tag the merge commit
0.22.0: the native builds and the GitHub release run from the tag.