Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Lash-L
force-pushed
the
feat/update-job
branch
from
October 22, 2026 01:25
1f62ec3 to
1020253
Compare
Collaborator
Author
|
separate from this PR - what are your thoughts about breaking up web_api Been thinking about biting the bullet and adding a bunch of web endpoints so that a lot of tricky functionality is possible (opens up a lot of doors for agents as well imo). But as this file gets longer and longer, I wonder if it should be separate files. e.g. /user/homes is in a 'homes' folder under web_api. and 'devices' and 'scenes', etc. |
Lash-L
marked this pull request as ready for review
October 22, 2026 01:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cloud job editing through the Python API and CLI.
RoborockApiClient.update_job(user_data, device_id, job)sendsPUT /user/devices/{duid}/jobs/{jobId}using aHomeDataSchedule. It uses the ID in the URL and sends the remaining schedule fields as a complete replacement, signing and sending identical compact JSON bytes without changing the input schedule.The CLI uses cached login credentials:
It parses the JSON file with the existing
HomeDataSchedule.from_dict()and callsupdate_job(). Parsing or update failures are printed with a nonzero exit status. Include the full schedule and existing cleaning parameters in the input file.Validation:
uv run pytest -q: 1,605 passed, 53 xfailed, 11 deselected.uv run pre-commit run --all-files: all hooks passed.tests/test_cli.pypassed.HTTP behavior is tested with mocks; no live account or device calls were made.