Repository navigation
CI: the engine builds from the pinned audioeffects as it is - #65
Merged
Merged
Conversation
The pinned audioeffects is now v0.5.2.dev1, whose AirSpace and ShimmerHall import on MicroPython, so the step that patched two lines of v0.5.2.dev0 before the build is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the workflow step that patched two lines of audioeffects v0.5.2.dev0 before the engine build. The pinned library now carries audioeffects v0.5.2.dev1, where
audioeffects.airspaceandaudioeffects.shimmerhallimport on MicroPython, so the plug-in's scan of its effects no longer needs the workaround.The engine cache key includes the module pins, which just moved, so this run builds the engine fresh from the unpatched tag and then runs the whole ctest suite against it. That run is the check.