Repository navigation
fix(dod): start no-mistakes validation in the commit turn - #17
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Regarding your wastes list, I would say go for all three. Since we're using a custom fork of firstmate, we need to be mindful of the upstream changes, especially when inefficiencies are patched and try to stay as current as possible. I do not want to optimize for the sake of optimization, rather I would like to see tangible refinements.
Context: the "wastes list" is three costs seen at the firstmate primary session on 2026-11-12: (1) idle supervision cycle-boundary wake-ups reach the primary, which re-reads its whole context to find nothing queued; (2) after a no-mistakes worker commits, the primary is woken only to tell it to start its validation run; (3) the context re-emit digest after a compaction is about 125 KB and the away return brief prints every held backlog item in full. The fork was synced with upstream on 2026-11-12 (Profreshor/firstmate PR 16); the sync report
~/firstmate/data/fork-upstream-sync-nov/report.md(section "The three wastes") found all three still open for a Claude-run primary and names the exact code owners.What Changed
done:for CI-ready PR or review outcomes.done:handoffs as legacy behavior in delivery gating and supervision guidance.Risk Assessment
🚨 High: The change leaves two explicitly required refinements unimplemented and cannot reliably distinguish a legacy validation handoff from a newly launched worker’s stale handoff.
Testing
An isolated disposable Firstmate lab generated the three real worker-facing brief variants and confirmed each starts validation in the commit turn, has no legacy handoff, and preserves the correct final ready report. Focused executable contracts passed. This is a CLI/generated-text surface, so rendered brief artifacts are the reviewer-visible evidence; no UI screenshot applies. No unrelated diff hunks were flagged.
{summary}handoff and Firstmate wake-up instruction.Evidence: Live standard no-mistakes worker brief
Source: Live standard no-mistakes worker brief
Evidence: Live manual-PR no-mistakes worker brief
Source: Live manual-PR no-mistakes worker brief
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
bin/fm-dod-lib.sh:685- The authoritative intent says to “go for all three,” but this range only changes the no-mistakes handoff (waste feat(bin): add guarded settings inspection tool #2). No changed behavior addresses idle cycle-boundary wakes reaching the primary (waste feat(backends): add Herdr crew pane workspaces #1) or the oversized post-compaction/away-return output (waste feat(bin): sync upstream fleet orchestration capabilities #3). Either add those two required refinements or explicitly narrow this change’s acceptance scope.bin/fm-dod-lib.sh:808- The new text calls pre-validationdone:“legacy,” but the gate still treats every no-mistakes non-CI-readydone:as legacy. A newly briefed worker that commits, appends the old summarydone:, and stops follows the ungated branch; validation supervision then wakes the primary to start validation—the failure this claims to remove. Distinguishing actual legacy briefs needs durable version/state information, so authorize that scope expansion or accept this as best-effort containment.✅ **Test** - passed
✅ No issues found.
{summary}handoff and Firstmate wake-up instruction.FM_HOME=<disposable fm-lab home> bash bin/fm-brief.shfor standard, manual-PR, and Gerrit no-mistakes ship briefs, with rendered brief assertions and evidence capturebash tests/fm-dod-lib.test.shbash tests/fm-brief.test.shgit diff 05317f863cf0fd8525dd566100788e95590dc8e4 24b18005e0c2abfad007ae48bf5f6d1b6a56a67a | jev find "a change unrelated to moving no-mistakes validation startup into the worker commit turn"✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.