Skip to content

FOUR-34054: Customizable file extension whitelist - #9109

Open
henryjonathanquispe wants to merge 1 commit into
developfrom
FOUR-34054
Open

henryjonathanquispe wants to merge 1 commit into
developfrom
FOUR-34054

Conversation

@henryjonathanquispe

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

Customizable file extension whitelist

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@cursor

cursor Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes file-upload security allowlists; incorrect env values could widen uploads or block valid files, though defaults are unchanged when env is not set.

Overview
Upload extension policy can now be tuned per deployment without editing config/files.php. Comma-separated ALLOWED_EXTENSIONS and DANGEROUS_EXTENSIONS in .env override the built-in lists; when unset or empty, the same default allow/deny sets as before are used.

Parsing normalizes entries (trim, lowercase, drop empties). .env.example documents the new variables, and FilesConfigTest covers defaults, env overrides, and dangerous-extension defaults.

Reviewed by Cursor Bugbot for commit eff0187. Bugbot is set up for automated code reviews on this repo. Configure here.

@decisions-sonarqube

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit eff0187. Configure here.

Comment thread config/files.php
@henryjonathanquispe henryjonathanquispe changed the title FOUR-34054: Customizable file extension whitelist FOUR-34054: Customizable file extension whitelist Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant