Repository navigation
Theme server: a Layout choice; PortMaster New's port info reworked - #384
Merged
Merged
Conversation
…t check A theme with #layouts (the default theme's List and Grid) was only ever drawn in its default layout: the page had no way to see the others, and --check only checked that one. - The page: Layout, next to Color scheme, for a theme with more than one. It's in the URL, every render, the editor's preview and the Translate view's screens. - Renderers switch layout in place, like the scheme (the load command and the zygote's spawn carry it; PortMasterGUI and ThemeEngine take force_layout). A layout the theme doesn't have means its default. - Export: --layouts all (or names) writes <theme>/<resolution>/<scheme>/<layout>/<lang>/<screen>; without it, the default layout and the same folders as before. The layout check reads either. - The default theme's layout test checks List and Grid at every size. - tools/theme_docs.py renders Grid with --layouts instead of a copy of the theme (the pictures come out the same, byte for byte). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NxABmR1rUUgi4iicVLZchY
On port info the screenshot's box is as wide as the description card below it, but the screenshot was drawn at its left edge. It's centred now (with its corner mask), and so is the ports list card's where its box is the card's whole width (the Grid layout, square screens). In the List layout it stays left, beside the details. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NxABmR1rUUgi4iicVLZchY
The details card's text was caption-sized and bunched at its top, and on wide screens the description was a thin strip under a tall image box. Port info is two panes now, with everything placed inside them, so only the panes' splits change with the screen's shape (it was every region's area, again for each shape): - the left column: the screenshot, then the description card filling the rest (a bigger share on wide screens) - the details card: status 22, labels 13, values 20, instructions 16, the rows spread down the card; two columns on wide screens, the instructions filling the rest Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NxABmR1rUUgi4iicVLZchY
On 16:9 and 3:2 screens the details card took over half the width for two short columns, and the screenshot shrank to fit a short box. The left column gets 70% now and the details card 30%, as wide as on 4:3, with the same one column of details and the same screenshot/description split. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NxABmR1rUUgi4iicVLZchY
Its screens started a renderer for it, which failed, and the editor's preview showed the renderer's whole traceback under the editor's own, plain, "A , is missing before this key". Now no renderer starts, and the preview says "theme.json has a mistake in it:" and the parser's message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NxABmR1rUUgi4iicVLZchY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The theme server only ever drew a theme in its default layout, so the default theme's Grid layout couldn't be previewed or checked. This adds a layout choice, and reworks PortMaster New's port info screen, which the previews showed was out of proportion.
This branch is on top of theme-docs (which includes theme-images): merge those first, or merge this one alone to get all three.
Theme server: layouts
PortMaster New: port info
Tested: the full suite on Python 3.7 and 3.13, the theme server tests on 3.12 and 3.14, and the flake8 errors-only lint.
🤖 Generated with Claude Code