Repository navigation
THEME.md: the whole theme reference, with pictures (and the image crash fix) - #383
Merged
Merged
Conversation
…t holds them
The image cache kept the 30 most recently loaded images and destroyed the
rest, including ones a region still held: a theme whose list pointer
wasn't in #resources crashed ("Cannot use a texture after it has been
destroyed") once enough port screenshots had loaded.
Now:
- theme images, found by name (the theme's files and PortMaster's:
#resources, a region's image, pimage and pointer, animation frames),
stay loaded until the theme reloads
- data images (screenshots and other absolute paths, QR codes) are cached
as before, and one a region still holds after the cache dropped it
loads itself again on its next draw
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NxABmR1rUUgi4iicVLZchY
The editor flagged the default theme's own #layouts ("PortMaster doesn't
use") and #info's default-layout. It now suggests the layout names for
default-layout and warns about one #layouts doesn't have. A test checks
the editor knows every key the default theme uses.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NxABmR1rUUgi4iicVLZchY
A rewrite of THEME.md as the reference for every theme key: files,
inheritance, capabilities, areas, colors, text, images, lists, the button
bar, templates, color schemes, styles, elements, layouts, translations,
sounds, animations, every screen with its required regions, every region
key and every tag, the theme server, and what older PortMasters do.
It corrects what the old one got wrong: areas are two corners (the old
one said x, y, width, height), {if:tag} is true when the tag isn't empty,
and a theme needs seven sections, not four (port_info, filter_list and
message_box too).
The pictures in docs/theme/ are real renders of the default theme, made
by tools/theme_docs.py with the theme server. tests/test_theme_docs.py
fails when the engine has a region key, screen, tag or section THEME.md
doesn't name, or a picture is missing.
The step-by-step guide, CREATING_A_THEME.md, is in PortMaster-Themes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NxABmR1rUUgi4iicVLZchY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THEME.md was a partial, unfinished reference: no color schemes, a third of the region keys and screens missing, and some of it wrong. This rewrites it as the reference for everything a theme can do, and fixes a crash it turned up.
This includes the image fix commit (theme-images): merge this one alone to get both.
The image crash
THEME.md
Theme editor
The step-by-step guide, CREATING_A_THEME.md, is a separate PR on PortMaster-Themes; THEME.md links to it.
Tested: the full suite on Python 3.7 and 3.13, the new tests on 3.12–3.14, and the flake8 errors-only lint.
🤖 Generated with Claude Code