Repository navigation
Conversation
…t holds them
The image cache kept the 30 most recently loaded images and destroyed the
rest, including ones a region still held: a theme whose list pointer
wasn't in #resources crashed ("Cannot use a texture after it has been
destroyed") once enough port screenshots had loaded.
Now:
- theme images, found by name (the theme's files and PortMaster's:
#resources, a region's image, pimage and pointer, animation frames),
stay loaded until the theme reloads
- data images (screenshots and other absolute paths, QR codes) are cached
as before, and one a region still holds after the cache dropped it
loads itself again on its next draw
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NxABmR1rUUgi4iicVLZchY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image cache kept the 30 most recently loaded images and destroyed the rest, including ones a region still held: a theme whose list pointer wasn't in #resources crashed ("Cannot use a texture after it has been destroyed") once enough port screenshots had loaded.
Now: