Skip to content

Simulator: the driver set's GCV objects, and which engine jar is missing - #134

Merged
jcombs-pointblue merged 1 commit into
masterfrom
sim-driverset-gcv-objects
Nov 13, 2026
Merged

jcombs-pointblue merged 1 commit into
masterfrom
sim-driverset-gcv-objects

Conversation

@jcombs-pointblue

Copy link
Copy Markdown
Contributor

Fixes for two DirXMLDevWeb issues reported on 2026-11-05. Both are in core; a web change will pin the release.

DirXMLDevWeb#187: GCV 'UAProvURL' is referenced but not defined. ExportWriter.toDriverXml builds the single-driver export the simulator runs. It carried the driver set's own GCVs and the Library objects the driver's own links reach, but not the GCV objects the driver set links (driverset.linkage.N, set 14). The engine loads those for every driver, so a policy naming one of their GCVs worked live and failed in the simulator. They now go in at the end of the export, so the driver's own values and the driver set's GCVs still win. Each one goes in once, and an unlinked Library GCV object stays out.

DirXMLDevWeb#186: ClassNotFoundException: com.jclark.xml.sax.CommentDriver. That class is in xp.jar, which 4.10.2 engines ship as xp-1.0.0.jar. The new EngineJars maps engine packages to their jars and says what to copy. simulate adds the hint to a case's error, and the web will use EngineJars.explain(Throwable) for its own runs.

Checked

  • New ExportWriterTest.singleDriverExportCarriesTheDriverSetsGcvObjects, which fails without the fix, and EngineJarsTest.
  • End to end on a Designer project (test11) whose driver set owns NOVLACOMSET-GCVs. I added ~UAProvURL~ to one policy in a scratch copy. Before the fix, idm simulate gave #187's error exactly; after it, the case runs.
  • With lib/xp.jar hidden, the case error now names xp.jar and xp-1.0.0.jar.
  • mvn test: 1062 tests, 0 failures.

🤖 Generated with Claude Code

The single-driver export the simulator runs carried the driver set's own GCVs
and the Library objects the driver links, but not the GCV objects the driver
set links. A policy naming a GCV only such an object defines (a UA package's
~UAProvURL~) failed with "referenced but not defined" (DirXMLDevWeb#187).
They now go in last, after every value the driver itself has.

A ClassNotFoundException out of the engine named only the class. EngineJars
maps it to the jar (com.jclark -> xp.jar, shipped as xp-1.0.0.jar from 4.10.2
on) and says where to copy it from; simulate adds that to the case's error
(DirXMLDevWeb#186).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jcombs-pointblue
jcombs-pointblue merged commit ee35250 into master Nov 13, 2026
4 checks passed
@jcombs-pointblue
jcombs-pointblue deleted the sim-driverset-gcv-objects branch November 13, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant