Repository navigation
Simulator: the driver set's GCV objects, and which engine jar is missing - #134
Merged
Merged
Conversation
The single-driver export the simulator runs carried the driver set's own GCVs and the Library objects the driver links, but not the GCV objects the driver set links. A policy naming a GCV only such an object defines (a UA package's ~UAProvURL~) failed with "referenced but not defined" (DirXMLDevWeb#187). They now go in last, after every value the driver itself has. A ClassNotFoundException out of the engine named only the class. EngineJars maps it to the jar (com.jclark -> xp.jar, shipped as xp-1.0.0.jar from 4.10.2 on) and says where to copy it from; simulate adds that to the case's error (DirXMLDevWeb#186). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for two DirXMLDevWeb issues reported on 2026-11-05. Both are in core; a web change will pin the release.
DirXMLDevWeb#187: GCV 'UAProvURL' is referenced but not defined.
ExportWriter.toDriverXmlbuilds the single-driver export the simulator runs. It carried the driver set's own GCVs and the Library objects the driver's own links reach, but not the GCV objects the driver set links (driverset.linkage.N, set 14). The engine loads those for every driver, so a policy naming one of their GCVs worked live and failed in the simulator. They now go in at the end of the export, so the driver's own values and the driver set's GCVs still win. Each one goes in once, and an unlinked Library GCV object stays out.DirXMLDevWeb#186: ClassNotFoundException: com.jclark.xml.sax.CommentDriver. That class is in
xp.jar, which 4.10.2 engines ship asxp-1.0.0.jar. The newEngineJarsmaps engine packages to their jars and says what to copy.simulateadds the hint to a case's error, and the web will useEngineJars.explain(Throwable)for its own runs.Checked
ExportWriterTest.singleDriverExportCarriesTheDriverSetsGcvObjects, which fails without the fix, andEngineJarsTest.NOVLACOMSET-GCVs. I added~UAProvURL~to one policy in a scratch copy. Before the fix,idm simulategave #187's error exactly; after it, the case runs.lib/xp.jarhidden, the case error now namesxp.jarandxp-1.0.0.jar.mvn test: 1062 tests, 0 failures.🤖 Generated with Claude Code