Repository navigation
Build instructions for Maven Central; a fresh clone builds - #132
Merged
Merged
Conversation
The require-engine enforcer rule checked for the simulator jar in ~/.m2 at validate, before Maven could fetch it, so a fresh clone stopped there even though the simulator is on Maven Central. It now checks the engine jars only. bin/install-deps fetches a pinned version that is on Central into ~/.m2 instead of skipping it, so bin/idm finds the simulator before the first build and every "run bin/install-deps" hint stays right. The docs drop building the simulator first: clone DirXMLDev, copy in the engine jars, run bin/install-deps, mvn test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: on a machine without the simulator in
~/.m2,mvn teststopped in therequire-engineenforcer rule. The rule checked fordirxml-simulator-1.9.0.jaratvalidate, before Maven could fetch it from Maven Central, andbin/install-depshad just said "on Maven Central, nothing to install". The rule now checks only the engine jars.Changed:
bin/install-depsfetches a pinned version that is on Central into~/.m2(mvn dependency:get), instead of skipping it.bin/idmputs the simulator on the class path from~/.m2, so it has to be there before the first build. This also keeps every existing "run bin/install-deps" hint inbin/idm,idm.cmdand doctor correct. The--helptext was cut short; it now prints the whole header.bin/install-deps,mvn test. Building the simulator is only for changing it.Verified with an empty home directory (empty
~/.m2):mvn test: 1058 tests, 0 failures; the simulator came from Central.bin/idm doctor: OK, simulator 1.9.0 found.install-depswith an emptyM2_REPO: fetched trace-core 1.12.0 and simulator 1.9.0;--listshows both installed.DirXMLDevWeb carries the same
install-deps; it gets the same change in a separate PR.🤖 Generated with Claude Code