Repository navigation
Integrate all reader formats and asynchronous book hashing - #141
Conversation
Closes #140. Pin reader b4aafaf and preserve original-format locations across import and reading.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Connects all seven supported formats—EPUB, PDF, MOBI, AZW3, TXT, CBR and CBZ—to the client reader and import flows. File-integrity hashing now runs asynchronously, and Back remains available while the book's media loads.
Closes #140. Covers the client integration portion of FR-3_1.
Depends on reader PR #25; merge the reader PR first. Both app/pubspec.yaml and app/pubspec.lock pin reader commit
b4aafafcb4d80afe5f140960ac91dcc251dac70e. The lockfile also resolves its nested Kindle decoder from that same Git revision. No local path override is committed.Changes
The reader's PDF conversion dependency requires archive 4.0.9 and image 4.9.2 in the resolved lockfile; those downgrades are intentional compatibility constraints, not unrelated package maintenance.
Validation
flutter pub get --enforce-lockfilepasses without modifying the manifest or lockfile. Client formatting, analyzer and all 22 JavaScript worker/bootstrap tests pass.Limits
Reader PR #25 records the complete seven-format stress observations. Huge MOBI/AZW3 files still show main-thread handoff stalls, legacy MOBI opens slowly, and whole-comic conversion has high peak memory. This PR does not establish uniformly non-blocking large-book behavior or NFR-4_2 acceptance.
Physical Android/iOS, low-memory devices and server upload/sync were not tested. The client debug stress session also logged two SQLite worker protocol errors (
installBroadcastUpdates) and route-semantics warnings; the final three import/read flows completed without additional scoped errors. That session is not an error-free runtime certification, and the SQLite mismatch remains uninvestigated.Downloaded large books, generated stress archives and local result screenshots are excluded from Git.