Skip to content

Adopt generated reader assets and remove obsolete client documentation - #137

Merged
Eoic merged 2 commits into
developmentfrom
maintenance/docs-sdk-cleanup
Nov 7, 2026
Merged

Eoic merged 2 commits into
developmentfrom
maintenance/docs-sdk-cleanup

Conversation

@Eoic

@Eoic Eoic commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Issue and requirements

Closes #136. Uses merged PapyrusReader/reader#23. Repository maintenance with no new product requirements.

Summary

Use Flutter 3.47.9 and pin the reader commit that generates its EPUB worker during web builds. Normalize calendar keys to native UTC DateTime values for compatibility with the upgraded Dart SDK.

Remove obsolete implementation notes and screenshots, retain installation, release and Windows testing guidance, and use uppercase Markdown filenames with updated references.

Testing

  • Fresh isolated checkout using the committed Git reader dependency: analysis, formatting, 2,262 Flutter tests (19 skipped), 21 JavaScript tests, and web release build passed.
  • Earlier integration validation: 3 Chrome tests and a macOS build passed, plus focused calendar and reader coverage.
  • Android debug APK builds passed locally for both Play and direct distribution after the toolchain update.
  • Maintained Markdown links checked across the affected repositories.

Compatibility and migration

Flutter 3.47.9 / Dart 3.13.7, Gradle 8.14.3, Android Gradle Plugin 8.11.1 and Kotlin 2.2.20. The Android toolchain meets the upgraded Flutter SDK's enforced minimum versions. No application version or stored-data migration. The dependency is a Git commit, with no local path override or generated CocoaPods lockfile included.

UI evidence

No visual redesign. Reader browser smoke coverage exercises EPUB/PDF reading, responsive settings, accessibility and resource cleanup in the companion reader PR.

Copilot AI balanced review requested due to automatic review settings November 7, 2026 22:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T22:23:26.706547Z 70d7d43 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Nov 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Eoic
Eoic merged commit fb838e0 into development Nov 7, 2026
10 checks passed
@Eoic
Eoic deleted the maintenance/docs-sdk-cleanup branch November 7, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt generated reader assets and retain only maintained client documentation

2 participants