Repository navigation
Require email verification before sign-in and preserve offline account data - #134
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c5c35d469
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Registration now ends at Check your email without installing credentials or an authenticated library. Opening a verification link verifies it automatically, then offers fresh sign-in; verification itself creates no session.
Issue and requirements
Closes #60.
Implements TASK-AUTH-03 for FR-1_1, FR-1_2, FR-1_3, and FR-1_4 against the accepted authentication contract and server PR #67. Automatic verification on opening the link is the maintainer-approved revision to the contract's explicit-confirmation step; the endpoint remains POST-only. Server PR #68 separately applies the shared transactional email template.
Summary
Testing
All client commands used the pinned SDK and isolated issue worktree, without the main checkout's reader override.
tools/papyrus check client: formatting and analysis clean; 21 Node web tests passed.flutter test --no-pub: 2,262 passed, 19 skipped on the final code.UI evidence
Browser previews of the actual auth widgets were reviewed at 390×844 and 1440×900, covering inbox/cooldown, automatic verification, success, expired links, and final button spacing. Light, dark, and e-ink previews were checked; widget coverage also exercises 320px widths and 2× text scaling. The previews use mocked responses. Independent UI review found no remaining material layout issues.
Compatibility and migration
No dependency, schema, or data migration changes.
APP_PUBLIC_BASE_URLmust serve the app at/verify-emailand/auth/callback, including deployment subpaths and SPA fallback. Shipauth_landing.js; align the configured API URL/prefix and Flutter base href.Notes
Live Google/SMTP/PowerSync smoke tests and native device/screen-reader acceptance were not run. Opt-in sync fixtures now provision verified disposable accounts and delete only those configured test accounts; those tests were not run. CI is separate from local validation. No merge, deployment, generated API snapshot changes, or requirement-verification updates are included. The project task remains In review.
Checklist