Skip to content

fix(STOP-457): safe repeat import and correct free BenID count - #206

Merged
vishwab1 merged 1 commit into
release-3.12.0from
vb/3.12.0-stop457-benid
Oct 14, 2026
Merged

vishwab1 merged 1 commit into
release-3.12.0from
vb/3.12.0-stop457-benid

Conversation

@vishwab1

Copy link
Copy Markdown
Member
  • saveGeneratedBenIDToLocalServer uses INSERT IGNORE, so importing the same IDs again (retry after a failed or partial import) skips existing rows instead of failing; returns the number really inserted.
  • checkAvailablBenIDLocalServer counts only IDs that are neither provisioned nor reserved by a registration in progress.

📋 Description

JIRA ID:

Please provide a summary of the change and the motivation behind it. Include relevant context and details.


✅ Type of Change

  • 🐞 Bug fix (non-breaking change which resolves an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🛠 Refactor (change that is neither a fix nor a new feature)
  • ⚙️ Config change (configuration file or build script updates)
  • 📚 Documentation (updates to docs or readme)
  • 🧪 Tests (adding new or updating existing tests)
  • 🎨 UI/UX (changes that affect the user interface)
  • 🚀 Performance (improves performance)
  • 🧹 Chore (miscellaneous changes that don't modify src or test files)

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

- saveGeneratedBenIDToLocalServer uses INSERT IGNORE, so importing the same
  IDs again (retry after a failed or partial import) skips existing rows
  instead of failing; returns the number really inserted.
- checkAvailablBenIDLocalServer counts only IDs that are neither provisioned
  nor reserved by a registration in progress.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5556dd3c-9d24-4262-88c7-87b6fa5c55e0
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@vishwab1
vishwab1 merged commit ad8e38d into release-3.12.0 Oct 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants