Repository navigation
chore: init_db.py in English without pip auto-install - #61
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes the last two partial findings of the code review:
init_db.pywas in Spanish while the UI and docs are in English, and it ranpip installon its own when a package was missing. Now every prompt and message is in English (y/n), and a missing dependency prints the list pluspip install -r requirements.txtand exits with code 1. The fallback.env(when there is neither.envnor.env.example) had stale holiday settings from before feat: holiday provider for any country (Nager.Date) #51 and a fixedSECRET_KEY; it now getsHOLIDAY_COUNTRY=ARand a random key, and the script asks for the holiday country when configuring.Employee.query.get(); they usedb.session.get()now. NoLegacyAPIWarningis left in the suite.Type of Change
Testing
install_missing_packagestests replaced by a test thatmain()exits and points torequirements.txt.pytest -W error::sqlalchemy.exc.LegacyAPIWarning(254 passed),black,isort,mypyclean.init_db.pyend to end on a scratch copy without.env: SQLite, migrations, login user, sample data; the generated.envhas the new keys.Screenshots
Not applicable: CLI script.
Checklist